Open Source & Linux Lab

It's better when it's simple

User Tools

Site Tools


etc:users:jcmvbkbc:linux-xtensa:patch-review-checklist

Patch review check list

  • If it has inline asm
    • Does it use specific instructions, does it correctly handle cores w/o such instructions
    • Does it correctly specify argument constraints (e.g. earlyclobber (=&) arguments)
    • Does it use possibly reserved registers (e.g. a7 with CONFIG_FRAME_POINTER)
etc/users/jcmvbkbc/linux-xtensa/patch-review-checklist.txt · Last modified: 2016/08/08 20:53 by kel